Configurable sliding window #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests went OK on my local machine. I assume it is kind of floating bug. |
fstab
reviewed
Aug 6, 2020
config/v3/configV3.go
Outdated
| @@ -211,6 +213,10 @@ func applyImportDefaults(metricConfig *MetricConfig, defaults DefaultConfig) { | |||
| if metricConfig.Type == "summary" && len(metricConfig.Quantiles) == 0 { | |||
| metricConfig.Quantiles = defaults.Quantiles | |||
| } | |||
| if metricConfig.Type == "summary" && metricConfig.MaxAge == 0 { | |||
| fmt.Print("set max age default") | |||
There was a problem hiding this comment.
Oh, sorry, didn't notice that one.
Removed now.
|
Looking good, thanks a lot. There's a BTW the Windows test on AppVeyor failed because in one of the file tailer tests a goroutine did not shut down properly. This has been flaky for a long time and has nothing to do with your PR. I'd love to know how to fix this though. |
added 2 commits
August 7, 2020 08:09
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue with configurable sliding window for summaries.