-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge #39 and #41 and add tests - bump to 0.19 #42
Conversation
…nto fix-vlan-notation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 4 4
Lines 235 235
=======================================
Hits 199 199
Misses 36 36
Continue to review full report at Codecov.
|
I'm new to python and generally not very skilled at writing tests, so thanks. The change you did to my regex brings the result in place with Important note is, that the regex as you changed it, will match invalid VLAN interfaces (they can only have numbers after the dot). P.S. The MTU PR has the number #39 |
Thanks @fdellwing - have changed the reference.
That's already added in |
Released in 0.19 |
Dear new Contributors @fdellwing @StoneJia - it'd nice to have tests for your contributions, so we can verify them :)