Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #39 and #41 and add tests - bump to 0.19 #42

Merged
merged 10 commits into from
Oct 9, 2019

Conversation

benjaoming
Copy link
Collaborator

Dear new Contributors @fdellwing @StoneJia - it'd nice to have tests for your contributions, so we can verify them :)

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files           4        4           
  Lines         235      235           
=======================================
  Hits          199      199           
  Misses         36       36
Impacted Files Coverage Δ
src/ifcfg/parser.py 80% <ø> (ø) ⬆️
src/ifcfg/__init__.py 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d846c7...f0748bb. Read the comment docs.

@benjaoming benjaoming changed the title Merge #38 and #41 and add tests Merge #38 and #41 and add tests - bump to 0.19 Oct 8, 2019
@fdellwing
Copy link
Contributor

fdellwing commented Oct 9, 2019

I'm new to python and generally not very skilled at writing tests, so thanks. The change you did to my regex brings the result in place with IUnixParser, so there could be an test added checking that.

Important note is, that the regex as you changed it, will match invalid VLAN interfaces (they can only have numbers after the dot).

P.S. The MTU PR has the number #39

@benjaoming benjaoming changed the title Merge #38 and #41 and add tests - bump to 0.19 Merge #39 and #41 and add tests - bump to 0.19 Oct 9, 2019
@benjaoming
Copy link
Collaborator Author

Thanks @fdellwing - have changed the reference.

so there could be an test added checking that.

That's already added in testss/ip_tests.py :)

@benjaoming benjaoming merged commit 2d6a87f into ftao:master Oct 9, 2019
@benjaoming
Copy link
Collaborator Author

Released in 0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants