Added default interface detection for Windows.. addresses issue #25 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, some interfaces report a |
Checking for `Default Gateway` that is `::` (IPv6 loopback) or in `127.0.0.0/8` (IPv4 loopback).
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 84.67% 85.01% +0.34%
==========================================
Files 4 4
Lines 261 267 +6
==========================================
+ Hits 221 227 +6
Misses 40 40
Continue to review full report at Codecov.
|
|
This addresses issue #25 |
ftao
approved these changes
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my understanding of
ipconfig /alloutput, the default interface self-advertises by listing a valid IP address asDefault Gateway. This PR integrates this into the theWindowsParserclass.