Interprocedural verification enhancement #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
And formatting can be done via |
s0mark
commented
Nov 21, 2023
| .changeVars(reverseLookup + additionalLookup) | ||
| val tempLookup = if (i > 0) getTempLookup(trace.actions[i - 1].edge.label).entries | ||
| .associateBy({ it.value }) { it.key } else emptyMap() | ||
| val precFromRef = refToPrec.toPrec(refutation, i).changeVars(tempLookup) |
There was a problem hiding this comment.
Thanks! Could you please look at the tests? For some reason they take forever now (47 minutes and still going): https://github.com/ftsrg/theta/actions/runs/6935056406?pr=244
The problem with the non-terminating multithreaded test is caused by removal of general parameters from the precision here (reverseLookup was deleted). This was necessary for recursive tasks, where the concrete variable instances of different procedure calls are needed in the precision in order to successfully verify them. This seems to cause problems for multithreaded tasks though, where we have instances of different threads. As a quick fix, we could omit reverseLookup when verifying recursive tasks and use it otherwise. We should discuss how to proceed on the long-term.
There was a problem hiding this comment.
Thanks for looking into it! I think we should discuss the next steps later, in person.
|
Unfortunately, regression test results are not too good: 339 tasks that were previously solved now throw an error. I've sent you the files for these results. unreach-call new problems |
|
Regression tests are done, everything seems OK, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a way of applying abstraction to location stacks, in order to reduce the size of the state space in interprocedural verification.