Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512 #1067

Closed
fujiapple852 opened this issue Mar 24, 2024 · 0 comments · Fixed by #1068
Closed

Reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512 #1067

fujiapple852 opened this issue Mar 24, 2024 · 0 comments · Fixed by #1068
Labels
enhancement New feature or request
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

Reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512

The Dublin multipath strategy for IPv6/udp encodes the sequence number in the payload length and consequently the maximum sequence number must be no larger than the maximum IPv6/udp payload size. It is important that the range of possible sequence numbers is at least BUFFER_SIZE to ensure delayed responses from a prior round are not incorrectly associated with later rounds.
@fujiapple852 fujiapple852 added triage enhancement New feature or request and removed triage labels Mar 24, 2024
@fujiapple852 fujiapple852 self-assigned this Mar 24, 2024
@fujiapple852 fujiapple852 added this to the 0.10.0 milestone Mar 24, 2024
fujiapple852 added a commit that referenced this issue Mar 24, 2024
@fujiapple852
feat(net): reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512 (#1067)
c4f9ab8
@fujiapple852 fujiapple852 mentioned this issue Mar 24, 2024
Merged
fujiapple852 added a commit that referenced this issue Mar 24, 2024
@fujiapple852
feat(net): reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512 (#1067)
df1c304
@fujiapple852 fujiapple852 removed their assignment Mar 29, 2024
fujiapple852 added a commit that referenced this issue Mar 29, 2024
@fujiapple852
chore: add items #1026, #272 & #1067 to CHANGELOG.md
7aef113
fujiapple852 added a commit that referenced this issue Mar 29, 2024
@fujiapple852
chore: add items #1026, #272 & #1067 to CHANGELOG.md
4f34d89
@chenrui333 chenrui333 mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

feat(net): reduce MAX_SEQUENCE_PER_ROUND from 1024 to 512 (#1067) fujiapple852/trippy
1 participant
@fujiapple852