Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracer panic for ICMP extension #1287

Closed
fujiapple852 opened this issue Aug 20, 2024 · 2 comments · Fixed by #1294
Closed

Tracer panic for ICMP extension #1287

fujiapple852 opened this issue Aug 20, 2024 · 2 comments · Fixed by #1294
Labels
bug Something isn't working icmp packet
Milestone
0.12.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Aug 20, 2024 •
edited
Loading

Tracer panic:

thread 'tracer-23144' panicked at crates/trippy-packet/src/icmp_extension.rs:426:33:
range end index 42973 out of range for slice of length 416

Attempting to reproduce and capture the offending packet.
@fujiapple852 fujiapple852 added the bug Something isn't working label Aug 20, 2024
@fujiapple852 fujiapple852 self-assigned this Aug 20, 2024
@fujiapple852 fujiapple852 added this to the 0.12.0 milestone Aug 20, 2024
fujiapple852 added a commit that referenced this issue Aug 21, 2024
@fujiapple852
fix(core): tracer panic for ICMP extension with malformed length (#1287)
2694b49
@fujiapple852 fujiapple852 mentioned this issue Aug 21, 2024
Merged
@fujiapple852
Copy link
Owner Author

Unable to reproduce whilst capturing packets. Instead I created a synthetic test case based on the error message and fixed based on that. Provisional fix in #1294.

fujiapple852 added a commit that referenced this issue Aug 21, 2024
@fujiapple852
fix(core): tracer panic for ICMP extension with malformed length (#1287)
4f91d55
fujiapple852 added a commit that referenced this issue Aug 21, 2024
@fujiapple852
doc: update CHANGELOG.md for #1290 and #1287
cdc955e
@fujiapple852
Copy link
Owner Author

Still unable to reproduce despite exhaustive attempts.

The change in #1294 fixes an issue and even if it does not fix the issue (it almost certainly does) it is still a valid fix and will be merged.

fujiapple852 added a commit that referenced this issue Aug 22, 2024
@fujiapple852
fix(core): tracer panic for ICMP extension with malformed length (#1287)
714f126
fujiapple852 added a commit that referenced this issue Aug 22, 2024
@fujiapple852
doc: update CHANGELOG.md for #1290 and #1287
316fb6c
@fujiapple852 fujiapple852 removed their assignment Aug 22, 2024
@BrewTestBot BrewTestBot mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working icmp packet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

fix(core): tracer panic for ICMP extension with malformed length (#1287) fujiapple852/trippy
1 participant
@fujiapple852