feat(tui): add Hindi (hi) locale
#1343
Conversation
fujiapple852
force-pushed
the
feat-i18n-hi
branch
from
d25d169 to
8d8acd4
Compare
|
Could you please assign me hindi issue to me @fujiapple852, I would love to contribute. |
|
Thanks @kiranyele18 ! |
|
could you explain how to merge changes? @fujiapple852 |
Do you mean the changes that you made? Did you clone the repo to do them? |
The changes that made by me. And fork the repo in github made changes and pull the request but not submitted yet. @fujiapple852 |
|
Thank you, I see the pull request that you created. #1378 . We'll review it and get back to you, thank you very much. |
fujiapple852
force-pushed
the
feat-i18n-hi
branch
2 times, most recently
from
1e4a9a0 to
c7d6ac1
Compare
crates/trippy-tui/locales/app.yml
Outdated
| @@ -1087,6 +1185,7 @@ column_sprt: | |||
| ru: "Исх" | |||
| es: "Sprt" | |||
| de: "Sprt" | |||
| hi: "स्रोत पोर्ट" | |||
There was a problem hiding this comment.
@kiranyele18 can this be abbreviated to a single word (no spaces)?
|
@kiranyele18 (cc @c-git) thank you for your contribution! I've taken all of your changes from #1378 and applied them here, the only change I made was to leave the technical terms (TCP/UDP etc) as English. The only issue I see is the column names that have spaces, I've opened specific threads about finding abbreviations for those. Here is how it currently looks: 
|
fujiapple852
force-pushed
the
feat-i18n-hi
branch
from
c7d6ac1 to
61b413b
Compare
|
@kiranyele18 can you comment on the open threads? They all relate to having spaces in column names, which we'd like to avoid. Thanks! |
fujiapple852
force-pushed
the
feat-i18n-hi
branch
2 times, most recently
from
80b6596 to
ba823f7
Compare
Co-authored-by: Kiran Yele <[email protected]>
fujiapple852
force-pushed
the
feat-i18n-hi
branch
from
ba823f7 to
7363415
Compare
|
It seems the "spaces" (as can be seen as black colored blocks in the screenshots above) are not spaces in the column names but rendering quirks in my terminal (iTerm2 on macOS). I don't know if it is going to be possible to support Hindi in terminal. |
|
Do you want me to try to see if I can find someone else to help with Hindi so we can determine if these can be fixed? |
No description provided.