[bufix] Batch submit jobs needs to filter the input keyword arguments #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have arguments that are None, then we have **not** include them as keyword arguments. See: https://github.com/vemel/mypy_boto3_builder/issues/30 See: boto/botocore#2075
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
========================================
+ Coverage 73.3% 77.3% +3.9%
========================================
Files 11 11
Lines 428 441 +13
Branches 52 45 -7
========================================
+ Hits 314 341 +27
+ Misses 94 89 -5
+ Partials 20 11 -9 |
nh13
commented
Jun 11, 2020
| @@ -244,17 +260,37 @@ def stream(self) -> Optional[str]: | |||
|
|
|||
| def submit(self) -> SubmitJobResponseTypeDef: | |||
| """Submits this job.""" | |||
|
|
|||
| # If we have arguments that are None, then we have **not** include them as keyword | |||
There was a problem hiding this comment.
Suggested change
| # If we have arguments that are None, then we have **not** include them as keyword | |
| # If we have arguments that are None, then we have to **not** include them as keyword |
sstadick
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have arguments that are None, then we have not include them as keyword
arguments.
See: https://github.com/vemel/mypy_boto3_builder/issues/30
See: boto/botocore#2075