Skip to content

Commit

Permalink
[docs] update promql query for istio request duration
Browse files Browse the repository at this point in the history
A minor issue I stumbled across while learning how to drive Flagger, is that the docs still use `istio_request_duration_seconds_bucket` to illustrate the query behind the `request-duration` metric. I understand that this changed with Istio 1.5 (fluxcd#478), but it seems that in the current version of flagger, the correct metric must already be used, since I'm getting duration metrics out of Istio 1.10 :)

This change simply makes the docs clearer for those of us trying to understand exactly what `request-duration` entails!

Signed-off-by: David Young <[email protected]>
  • Loading branch information
funkypenguin committed Sep 19, 2021
1 parent e8b1740 commit a2b58d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/gitbook/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ Istio query:
histogram_quantile(0.99,
sum(
irate(
istio_request_duration_seconds_bucket{
istio_request_duration_milliseconds_bucket{
reporter="destination",
destination_workload=~"$workload",
destination_workload_namespace=~"$namespace"
Expand Down

0 comments on commit a2b58d5

Please sign in to comment.