Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dot-viewer in TUI #7
dot-viewer in TUI #7
Changes from 250 commits
1639a6c
68f647b
b413422
9229cd5
bd7b4cc
8e0eb97
1790601
5d5a780
e37d51f
6573659
f8d6e64
53c9e0d
90568a1
d1e7866
811cda8
dd16ba8
c0f403c
b9aaec5
fddec68
a4aa701
4320aae
7bb88fe
77c8658
0868c1a
d3633e0
2b61020
9ab5fba
d353a93
55a67ef
1cb9504
d9a1309
6f8569a
eda6c44
a5a1730
84f40f3
359ec08
0d6bb54
fd11195
65e02cd
e0bdd44
e5ae467
a142ff8
8f900c9
3052cab
cdc2ca0
ffc5470
6f76cf9
87819e1
76f1f1e
227966e
5ca25b7
a8a0065
668ceb4
699a28e
1718e87
c8abaf4
f61f958
1ecedcb
1ce68ee
5f0dc0b
bb30473
dc42c7e
eba9d64
6350c5c
32239e5
adfa0c6
dabf4a8
28be06a
d57611d
644928e
754b76b
0db6fbc
e216232
08418c9
3f57f7c
4c4054c
5159ccd
1711476
079151e
171f012
774950d
a6ed878
50b7d14
0397467
c8df475
0ec4ece
5ae54eb
0f82419
af8d802
b28d3f2
a7a6898
455f947
9a88f90
afbacd2
79c2134
0270702
ad745c8
8e24d6b
56a5cec
8a09a6c
c4123ea
0c58110
555f99a
bb28baa
212fd7f
2e82d17
e7b6117
ec91f1e
c978ab1
88e4831
87e3fad
ffcd8f0
1c0a797
bffc593
d3d4d02
7e70882
3ef8c33
1d5b3a2
74d030b
a10fa75
ff367cf
8237cfc
1a29844
07eea5a
4c8949c
be930c1
821d93d
ae1f0e6
cebf5ec
78198ce
7e8b894
b149710
c21d611
5d73098
34882e3
385e242
8b8f8ad
2e78c7f
69a1aad
406e692
60184fb
5c61e93
9158323
f9ed0fb
d9f0321
3575aa7
54ca904
922594d
7a35a04
cc724d2
7c8f109
ceae0ce
8c43fac
c44fe6c
b12c27c
5b2e634
63d2570
fe6ac15
8493a5e
0015bc5
67f318a
792b969
2fe7d79
9a5dd8a
34573fa
8e96d4a
962a5a5
5b3122e
c4c86f0
c57a43e
3e8dcfb
a43d885
5f37437
834b18d
b55afe3
72ce24f
75e6729
720fc94
66c0977
dc78a03
29031e8
2a26a29
595d1b8
bc14c5e
e90d6f7
66a7ac3
2b7dd13
20e1436
86f31bb
ce7bae6
9bbcd6d
98e3a24
1c44fbd
fa43a97
0878cbb
adfb375
1f18e78
e2abbc0
42d1f21
11a6e5f
6feb76a
4cb4ef4
2f2d2a9
22c8ffb
45a3af5
b6e1183
209f293
0772b4d
1858ab7
62abc0d
dd8f8ff
610ad87
f1dad60
e95ca8d
8891075
22512be
27f16a1
a372127
328c542
b4f9869
160a87d
df08507
0a6af95
5b61c04
4f9c224
468b71e
f4b4a5c
d7c8c48
fe1ef41
1f42289
ff77711
e876fab
00c244d
22a3634
384a545
a886c92
1fe4285
3022aae
103a188
3a79dd0
c608ccb
6a7841a
c0f8c43
b644832
cd3c7e7
3555ecd
b77bb46
4578f30
7676830
92faa12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 dot-graph 빌드시에는 graphviz를 찾을 수 없다고 떠서 이 부분은 따로 얘기하도록 하겠습니다.
dot-viewer는 설치를 한다고 하면 플렛폼마다 설치하는 환경이 달라서 각기 다른 방식으로 빌드를 해야 합니다.
이 부분을 관리를 하는 것이
.cargo/config.toml
입니다.https://doc.rust-lang.org/cargo/reference/config.html
여기서 각 환경마다 어떤 인자를 줄껀지 설정을 할 수 있습니다.
제가 실행한 환경(apple m1)에서는 빌드가 되지 않았늗데 이는 homebrew로 설치된 library path를 linker한테 따로 지정하지 않아 생긴 문제였습니다.
그래서 linker한테 homebrew에 설치된 path도 찾을 수 있도록 인자를 전달해야 합니다.
위의 설정의 뜻은 apple arm으로 빌드 진행할 시 linker한테(여기서는 ld 기준) /opt/homebrew/lib 도 library search path 목록에 추가하라는 뜻입니다.
위와 같이 config.toml 파일을 추가해서 사용자가 환경 변수 설정하는 번거로움을 줄이는 게 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fa43a97
dot-viewer
,dot-graph
양쪽에 M1 mac에 대해.cargo/config.toml
추가했습니다.나머지 플랫폼에 대해서는 차후에 CI 구축과 함께 진행하겠습니다 :)