-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve socket error handling #414
Conversation
Thanks for this... could you also check if the socket is readable? I recall that some linux distributions require group access to the socket. |
@fussybeaver , i got my friend's linux pc, and tested it it is working, not asking for any permission |
it is running pop os
|
let me know what is show stopper for this PR, and what i can improve? |
src/docker.rs
Outdated
@@ -4,6 +4,7 @@ use std::fs; | |||
use std::future::Future; | |||
#[cfg(feature = "ssl")] | |||
use std::io; | |||
use std::path::Path; | |||
#[cfg(feature = "ssl")] | |||
use std::path::{Path, PathBuf}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing because the ssl
feature conflicts with this changeset
All ci/cd's are green except docs one, i tried to check the logs but didn't understand why it is falling |
It looks like a doctest is failing, try adding a bollard/src/grpc/driver/docker_container.rs Line 121 in 9435d91
|
now something new is failing |
@fussybeaver All Green |
@fussybeaver Hi, can you kindly release a patch version of this crate with this change? I am facing this
I am using |
After patching the
The error I get is:
After enabling the I solved this by following the lando/lando#3533 thread. But following the testcontainers/testcontainers-java#6045 and lando/lando#3533 threads, it seems that in macOS docker desktop opens the
So on macOS, Thank you for this crate! ❤️ |
I am new to rust, I was building docker tui, and came across the same issue as #383, i tried to fix this,
I don't know what other things I need to fix or add, this is going to be my 1st PR for rust, so if any issues need to be addressed please let me know,
closes #383
had this question:
thankyou for creating this lib, it is helping me a lot!!