Add support for the docker /images/{}/get API endpoint #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing the ability to export images, was previously loading the whole file into memory. This failed with the much larger Windows images. Tests now export the image to a temporary file, and then delete it after.
fussybeaver
approved these changes
Jan 8, 2020
|
I don't have access to merge, but it's all set. I have another commit with image import functionality, but it changes the API a little bit so should probably be a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in writing Rust code to work with importing and exporting images, and creating them from scratch. I added a method to export images from the current daemon as TAR archives. Interested in adding image import functionality in the future.
This commit
Docker::export_imagefunction, which calls the /images/{name}/get method of the API to return a TAR archive of image data. The new code is in/src/images/rs.Docker::export_imageintests/image_test.rs