Add upload_to_container_streaming to Container #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload_to_container required loading the entire file into memory which was inefficient (sometimes impossible) for large files that can be streamed from disk or network.
|
Fabulous! The previous streaming implementation wrote this test: https://github.com/russelltg/bollard/blob/15ace255bd8f22d566855ab862e1cdb2e16a7cf7/tests/image_test.rs#L1014-L1044 .. which is just a roundtrip test, so it could be similar test. |
|
Fabulous.. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload_to_container required loading the entire file into memory which was inefficient (sometimes impossible) for large files that can be streamed from disk or network.
Our use case is recreating containers with backups of the container's volumes stored in an S3 bucket. The backups are created with download_from_container which already supports streaming. Currently for us these volumes can be large and due to the limitations of upload_to_container would cause our demo server (with 1GiB of ram) to quickly run out of memory (especially if multiple customers tried to restore backups).