Optional builtin http client #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the custom transport implementation we're able to provide a sans-io bollard crate. This also remove the hard dependency on tokio making possible to use other async runtime. When the disabling default options (http, pipe), fresh compile time is reduced from ~24s to ~14s and rlib size from ~24MiB to ~11MiB.
|
Hi, thanks for the PR and sorry for the delay in reviewing. This looks great, I've been thinking it would be great to be able to support other runtimes. |
fussybeaver
reviewed
Sep 30, 2024
|
Thanks, I think this opens the door to a more flexible library. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the custom transport implementation we're
able to provide a sans-io bollard crate.
This also remove the hard dependency on
tokio making possible to use other async runtime.
When the disabling default options (http, pipe),
fresh compile time is reduced from ~24s to ~14s
and rlib size from ~24MiB to ~11MiB.