Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): support dnf modules #1114

Merged
merged 6 commits into from
Jan 6, 2021
Merged

feat(scan): support dnf modules #1114

merged 6 commits into from
Jan 6, 2021

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Jan 4, 2021

What did you implement:

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/installing_managing_and_removing_user-space_components/index

vulsio/goval-dictionary#118

The schema of goval-dictionary has been changed.
Please upgrade goval-dictionary to 0.3.0 or later and re-fetch to a new database.
(No automatic migration, so use a new database.)
If vuls and goval-dictionary are old, false positives will occur on RHEL8.

models.ScanResults.EnabledDnfModules added
https://github.com/future-architect/vuls/pull/1114/files#diff-1746284de583f13f0d85cd8a94fd0633f5f5fdf9f9bb0861b1b77fd3e4384e8bR51

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

./scan, ./report

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe changed the title [WIP]feat(scan): support dnf modules feat(scan): support dnf modules Jan 5, 2021
@kotakanbe kotakanbe changed the title feat(scan): support dnf modules [WIP]feat(scan): support dnf modules Jan 5, 2021
@kotakanbe kotakanbe changed the title [WIP]feat(scan): support dnf modules feat(scan): support dnf modules Jan 6, 2021
@kotakanbe kotakanbe merged commit b13f93a into master Jan 6, 2021
@kotakanbe kotakanbe deleted the dnf-modules branch January 12, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant