Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saas) change saas upload s3 key #1116

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix(saas) change saas upload s3 key #1116

merged 1 commit into from
Jan 27, 2021

Conversation

sadayuki-matsuno
Copy link
Collaborator

@sadayuki-matsuno sadayuki-matsuno commented Jan 6, 2021

What did you implement:

Changed the format of s3 key of saas option
Erase time information from s3 key

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe
Copy link
Member

NLM

@kotakanbe kotakanbe merged commit a8c0926 into master Jan 27, 2021
kotakanbe pushed a commit that referenced this pull request Jan 28, 2021
kotakanbe added a commit that referenced this pull request Jan 28, 2021
* fix(saas) change saas upload s3 key (#1116)

* fix(report): remove retry logic for wpscan.com

Co-authored-by: sadayuki-matsuno <[email protected]>
@kotakanbe kotakanbe deleted the fix_saas_uplaod_key branch January 30, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants