Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report) : display diff status (--diff-plus, --diff-minus option added to report and tui) #1157

Merged
merged 23 commits into from
Feb 9, 2021

Conversation

kazuminn
Copy link
Contributor

@kazuminn kazuminn commented Jan 30, 2021

./vuls tui -diff
Inked107286566-19810a00-6aa4-11eb-85b5-2ae8da43db95_LI

./vuls report -format-list -diff
Inked107286406-e76fa800-6aa3-11eb-9517-9ce0cb569d39_LI

./vuls report -format-full-text -diff
Inked107286429-edfe1f80-6aa3-11eb-9eb6-befddcb27a44_LI

./vuls report -format-one-line-text -diff
Inked107286443-f3f40080-6aa3-11eb-8fe1-b18bed50b613_LI

This patch has the function to output the resolved(patched) CVEs compared to the previous JSON.

--diff option turns on both options -diff-plus and -diff-minus

Document pull request : vulsdoc/vuls#140

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kazuminn kazuminn changed the title [WIP] Differences between vulnerability patched items [WIP] feat(report) : Differences between vulnerability patched items Jan 30, 2021
@kazuminn kazuminn changed the title [WIP] feat(report) : Differences between vulnerability patched items feat(report) : Differences between vulnerability patched items Feb 4, 2021
Copy link
Member

@kotakanbe kotakanbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I reviewed it

@kotakanbe kotakanbe merged commit 4c04acb into future-architect:master Feb 9, 2021
@kotakanbe kotakanbe changed the title feat(report) : Differences between vulnerability patched items feat(report) : display diff status (--diff-plus, --diff-minus option added to report and tui) Feb 9, 2021
@kazuminn kazuminn deleted the minusDiff-plusDirr branch February 10, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants