Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ms): import gost:MaineK00n/new-windows #1481

Merged
merged 7 commits into from
Jul 4, 2022
Merged

feat(ms): import gost:MaineK00n/new-windows #1481

merged 7 commits into from
Jul 4, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Jun 15, 2022 •
edited
Loading

What did you implement:

Import gost:MaineK00n/new-windows and use DetectCVE to detect CVEs.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Jun 15, 2022
@MaineK00n MaineK00n force-pushed the MaineK00n/gost-new-windows branch from 7075a10 to 32da841 Compare June 15, 2022 09:13
@MaineK00n MaineK00n force-pushed the MaineK00n/gost-new-windows branch from 4adb85c to ff9f0c2 Compare June 29, 2022 14:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 29, 2022
View reviewed changes
gost/microsoft.go
var osName string
osName, ok := r.Optional["OSName"].(string)
if !ok {
logging.Log.Warnf("This Windows has wrong type option(OSName). UUID: %s", r.ServerUUID)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
gost/microsoft.go
products = append(products, p)
}
case nil:
logging.Log.Warnf("This Windows has no option(InstalledProducts). UUID: %s", r.ServerUUID)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
gost/microsoft.go
unapplied[strings.TrimPrefix(kbID, "KB")] = struct{}{}
}
case nil:
logging.Log.Warnf("This Windows has no option(KBID). UUID: %s", r.ServerUUID)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
gost/microsoft.go
applied[strings.TrimPrefix(kbID, "KB")] = struct{}{}
}
case nil:
logging.Log.Warnf("This Windows has no option(AppliedKBID). UUID: %s", r.ServerUUID)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
gost/microsoft.go
unapplied[strings.TrimPrefix(kbID, "KB")] = struct{}{}
}
case nil:
logging.Log.Warnf("This Windows has no option(UnappliedKBID). UUID: %s", r.ServerUUID)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
gost/microsoft.go
}
}

logging.Log.Debugf(`GetCvesByMicrosoftKBID query body {"osName": %s, "installedProducts": %q, "applied": %q, "unapplied: %q"}`, osName, products, maps.Keys(applied), maps.Keys(unapplied))

Check failure

Code scanning / CodeQL

Log entries created from user input

This log write receives unsanitized user input from [here](1).
@MaineK00n MaineK00n force-pushed the MaineK00n/gost-new-windows branch 3 times, most recently from 6181377 to ae2042e Compare June 30, 2022 18:19
@MaineK00n MaineK00n force-pushed the MaineK00n/gost-new-windows branch from ae2042e to 21cde74 Compare July 4, 2022 05:19
@MaineK00n MaineK00n marked this pull request as ready for review July 4, 2022 05:20
sadayuki-matsuno
sadayuki-matsuno approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@sadayuki-matsuno sadayuki-matsuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadayuki-matsuno sadayuki-matsuno merged commit 48f7597 into master Jul 4, 2022
@sadayuki-matsuno sadayuki-matsuno deleted the MaineK00n/gost-new-windows branch July 4, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadayuki-matsuno sadayuki-matsuno sadayuki-matsuno approved these changes

Assignees

@MaineK00n MaineK00n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaineK00n @sadayuki-matsuno