Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ubuntu): dependency problem #1597

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix(ubuntu): dependency problem #1597

merged 1 commit into from
Feb 8, 2023

Conversation

kl-sinclair
Copy link
Collaborator

@kl-sinclair kl-sinclair commented Feb 8, 2023 •
edited
Loading

What did you implement:

gost/Ubuntu.ConvertToModel() is public method now

Type of change

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@kl-sinclair kl-sinclair self-assigned this Feb 8, 2023
@MaineK00n MaineK00n removed their request for review February 8, 2023 01:59
@kl-sinclair kl-sinclair changed the title fix(ubuntu): fix(ubuntu): dependency problem Feb 8, 2023
@kl-sinclair kl-sinclair marked this pull request as ready for review February 8, 2023 02:26
@kotakanbe kotakanbe merged commit 7044929 into future-architect:master Feb 8, 2023
@kl-sinclair kl-sinclair deleted the fix-ubuntu-gost-only branch February 8, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotakanbe kotakanbe Awaiting requested review from kotakanbe

Assignees

@kl-sinclair kl-sinclair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kl-sinclair @kotakanbe