Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): Critical Bug Fix for CPE based scanning #793 #794

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Mar 22, 2019

What did you implement:

Fixes #793

Fixed a bug that could not be detected under certain conditions during CPE-based scanning.
Everyone using CPE based match should update Vuls to the latest version. There is no need to re-fetch DB, as it is guaranteed to be backward compatible.

For Details, see https://github.com/kotakanbe/go-cve-dictionary/pull/123/files

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit e26fd0b into master Mar 22, 2019
@kotakanbe kotakanbe deleted the cpe-match branch June 13, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(report): Failed to detect CVE-2019-1608 with CPEName: cpe:/o:cisco:nx-os:6.0%282%29a6%288%29
1 participant