Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update goval-dictionary dependency to valid version #839

Merged

Conversation

a129722
Copy link
Contributor

@a129722 a129722 commented Jun 13, 2019

What did you implement:

Updated go.mod to use valid version of goval-dictionary -- v0.1.3-0.20190613053258-078b163b76ec

Fixes #838

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

make install
make test

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes

@kotakanbe kotakanbe merged commit 77b5df8 into future-architect:master Jun 14, 2019
@kotakanbe
Copy link
Member

@a129722

Many Thanks :)

@a129722
Copy link
Contributor Author

a129722 commented Jun 14, 2019

Thank you, @kotakanbe ! Appreciate the tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install error during vet step
2 participants