Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template for PRs - to automate #899

Merged
merged 5 commits into from
Nov 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 113 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,114 @@
**PR checklist**
# Description

- [ ] Describe the added/changed/fixed/removed behaviour
- [ ] Tag related issue(s)
- [ ] Add appropriate unit tests and/or integration tests to the [integration test repository](https://github.com/futureversecom/seed-integration-tests)
- _Provide a general description of the changes in this PR_

## Context & Background

- _Add any relevant context or background information about the changes_

## Notes & Additional Information

- _Any additional notes, considerations, or explanations_

## Related Issues

- _Link any related issues_

---

<!-- This section will be used to automatically generate release notes -->
<!-- Please fill out relevant sections below based on your changes -->
<!-- Remove sections if there are no changes -->

# Release Notes

## Key Changes

## Type of Change

- [ ] Runtime Changes
- [ ] Client Changes

## API Changes

### EVM Precompile Changes

#### Added

- _e.g. **Marketplace: `sellNft`**_

#### Changed

-

#### Removed

-

### Storage Changes

#### Added

zees-dev marked this conversation as resolved.
Show resolved Hide resolved
- _e.g. **XRPLBridge: PaymentDelay, changed from value to map keyed by asset_id**_

#### Changed

-

#### Removed

-

### Extrinsic Changes

#### Added

-

#### Changed

- _e.g. **XRPLBridge: set_payment_delay, added asset_id**_

#### Removed

-

### Event Changes

#### Added

- _e.g. **XRPL-Bridge: XrplAssetMapSet**_

#### Changed

- _e.g. **XRPLBridge: PaymentDelaySet, added asset_id parameter**_

#### Removed

-

### Error Messages

#### Added

- _e.g. **Marketplace: NoToken**_

#### Changed

-

#### Removed

-

## Storage Migrations

#### Added

- _e.g. **XRPLBridge: Migrate PaymentDelay to include asset_id as key**_

#### Removed

-

---