Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check NFI Data before emitting event on burn #915

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Check NFI Data before emitting event on burn #915

merged 6 commits into from
Jan 15, 2025

Conversation

JasonTulp
Copy link
Contributor

Description

  • Previously the NFI pallet emitted an event whenever a token was burnt to say the data was removed, even if no data was removed. This change performs a simple check to see whether the data existed in the NFI pallet before emitting the event.
  • This change also adds U256 support for multichain token ids

Related Issues

Release Notes

Key Changes

  • Checks if NFI data exists before emitting dataRemoved event

Type of Change

  • Runtime Changes
  • Client Changes

zees-dev
zees-dev approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JasonTulp JasonTulp merged commit a70f58f into main Jan 15, 2025
2 checks passed
@JasonTulp JasonTulp deleted the fix/nfi-burn-event branch January 15, 2025 02:43
@surangap surangap mentioned this pull request Jan 17, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zees-dev zees-dev zees-dev approved these changes

@surangap surangap surangap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonTulp @surangap @zees-dev