Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-276] [BUG] Turning analytics on causes hanging in the analytics service #168

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/matcha_ml/services/analytics_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
This approach to collecting usage data was inspired by ZenML; source: https://github.com/zenml-io/zenml/blob/main/src/zenml/utils/analytics_utils.py
"""
import functools
import logging
from enum import Enum
from time import perf_counter
from typing import Any, Callable, Optional, Tuple
Expand All @@ -15,7 +16,10 @@
from matcha_ml.services.global_parameters_service import GlobalParameters
from matcha_ml.state import MatchaState, MatchaStateService

analytics.write_key = "qwBKAvY6MEUvv5XIs4rE07ohf5neT3sx"
WRITE_KEY = "qwBKAvY6MEUvv5XIs4rE07ohf5neT3sx"

# Suppress Segment warnings
logging.getLogger("segment").setLevel(logging.FATAL)


class AnalyticsEvent(str, Enum):
Expand Down Expand Up @@ -57,6 +61,9 @@ def decorator(func: Callable[..., Any]) -> Callable[..., Any]:

Args:
func (Callable[..., Any]): The function that is being decorated

Returns:
Callable[..., Any]: The function that is being decorated
"""

@functools.wraps(func)
Expand Down Expand Up @@ -110,7 +117,9 @@ def inner(*args: Any, **kwargs: Any) -> Any:
result, error_code = execute_analytics_event(func, *args, **kwargs)
te = perf_counter()

analytics.track(
client = analytics.Client(WRITE_KEY, max_retries=1, debug=False)

client.track(
global_params.user_id,
event_name.value,
{
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def mocked_segment_track_decorator():
MagicMock: Mocked segment track function.
"""
with patch(
"matcha_ml.services.analytics_service.analytics.track"
"matcha_ml.services.analytics_service.analytics.Client.track"
) as track_analytics:
track_analytics.return_value = None

Expand Down