Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-286] Add documentation on "stacks" and the new LLM stack #189

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented Aug 8, 2023

This PR adds a brief section into the docs about "stacks" and what is included in the LLM stack.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@Christopher-Norman Christopher-Norman added the documentation Improvements or additions to documentation label Aug 8, 2023
@Christopher-Norman Christopher-Norman self-assigned this Aug 8, 2023
@Christopher-Norman Christopher-Norman changed the base branch from develop to feature/llm-stack August 8, 2023 14:00
Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 🌯 See comments

Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It feels like the stack subsections are missing something, perhaps more detail a little detail about the two and their components. Plus I think we can link to other parts of the documentation here too, like the API and getting started.

Copy link
Contributor

@KirsoppJ KirsoppJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just a couple of niggles

Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Christopher-Norman Christopher-Norman merged commit 639881d into feature/llm-stack Aug 11, 2023
@Christopher-Norman Christopher-Norman deleted the RPD-286-stack-documentation branch August 11, 2023 09:21
JonoCX added a commit that referenced this pull request Aug 15, 2023
* [RPD-282] adds stack cli command (#179)

* adds tests and logic for stack and stack set cli commands

* fixes typos

* updated for comments

* addresses comments

* [RPD-285] Create LLM stack Terraform files (#182)

* Add initial LLM Terraform files

* Update Terraform Kubernetes Chroma deployment

* Update Terraform docs

* Revert default variables

* Add missing aks module

* [RPD-283] add core function for updating stack type (#185)

* [RPD-287] ZenML version inference for zenserver (#180)

* various changes

* change variable names to make things more clear

* shubham's comment

* test for latest

* update existing tests

* update existing tests

* shubham latest comment

* add gitflow notation branches to ci (#183)

* remove old, commented out code

* [RPD-260] Add an object to handle the `matcha.config.json` file. (#184)

* adds logic and tests for matcha config module

* updates docstrings

* adds tests and implements config object throughout matcha

* updated for pr comments

* updates docstring

* fixes ci

* updates for comments

* enum and metaclass

* enum and metaclass

* bug removal

* docstring stack_set

* docstring file exists

* fix current tests

* add a couple tests, move logic for updating to configservice

* lowercase-ify arg to enum

* american spelling

* american spelling

* chris' comment re overwriting

* friendlier api

* Runtime error if not recognised arg type fpor update()

* Runtime error if not recognised arg type fpor update()

* update provision to use new update() API

* update stack name

* tests

* tests

* tests

* quote marks

* type version, mypy

* various review comments

* test for update() function

* update tests to include quotes.

* fixing tests

* tidy tests, test error if resources provisioned

* clearer error handling

* remove unnecessary context

* update test to new error type

---------

Co-authored-by: Callum Wells <[email protected]>

* [RPD-286] Add documentation on "stacks" and the new LLM stack (#189)

* Initial version of docs

* Add motivation to stacks docs

* Various docs updates based on reviews

* [RPD-284] Update AzureRunner to select the Terraform files corresponding to the stack name in the config file (#187)

* [RPD-287] ZenML version inference for zenserver (#180)

* various changes

* change variable names to make things more clear

* shubham's comment

* test for latest

* update existing tests

* update existing tests

* shubham latest comment

* add gitflow notation branches to ci (#183)

* remove old, commented out code

* [RPD-260] Add an object to handle the `matcha.config.json` file. (#184)

* adds logic and tests for matcha config module

* updates docstrings

* adds tests and implements config object throughout matcha

* updated for pr comments

* updates docstring

* fixes ci

* updates for comments

* enum and metaclass

* enum and metaclass

* bug removal

* docstring stack_set

* docstring file exists

* fix current tests

* add a couple tests, move logic for updating to configservice

* lowercase-ify arg to enum

* american spelling

* american spelling

* chris' comment re overwriting

* friendlier api

* Runtime error if not recognised arg type fpor update()

* Runtime error if not recognised arg type fpor update()

* update provision to use new update() API

* update stack name

* tests

* tests

* tests

* Move files for selection

* Clean up file

* Remove a test that no longer describes the expected functionality

* Remove a test that no longer describes the expected functionality

* Fix tests

* Stop creation of config file in local directory when running tests

* Update check to use MatchaConfig object instead of to dict

* Add get current stack name function to MatchaConfigService

* Update get stack function

* Fix test

* Remove unnecessary lower casing

* Fix tests

* updates stack handling

* Revert "updates stack handling"

This reverts commit b42b31d.

* [RPD-289] Update the Chroma Terraform within the LLM stack to use Helm #194

* [RPD-292] [BUG] Update AzureTemplate to not create redundant folders during provisioning (#195)

* splits default stack

* updates llm stack

* [RPD-303] Update stack_set docstring to include example and raises (#196)

---------

Co-authored-by: Callum Wells <[email protected]>
Co-authored-by: KirsoppJ <[email protected]>
Co-authored-by: Jonathan Carlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants