Skip to content

Commit

Permalink
Send_ConfigInfo: don't send monitor info
Browse files Browse the repository at this point in the history
When a module requests information about what it needs to know, it does
so to fvwm by asking "Send_ConfigInfo".  However, if this happens, and
fvwm is already sending information to all modules (such as via a
DesktopSize command), then an infinite loop can take place.

Fixes #997
  • Loading branch information
ThomasAdam committed Apr 10, 2024
1 parent 1920391 commit b10bfb2
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion fvwm/modconf.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,13 @@ void CMD_Send_ConfigInfo(F_CMD_ARGS)
int match_len = 0;
fmodule *mod = exc->m.module;

send_monitor_list(mod);
/* Don't send the monitor list when a module asks for its
* configuration... in this case, fvwm -> module could get in an
* infinite loop, continually telling that module the same
* information over and over.
*
* send_monitor_list(mod);
*/
send_desktop_geometry(mod);
/* send ImagePath and ColorLimit first */
send_image_path(mod);
Expand Down

0 comments on commit b10bfb2

Please sign in to comment.