-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FvwmScript core dump on signal 6 when called with (LaunchScript $FOO) from another FvwmScript #356
Comments
Ensure the malloc()d space to the string is computed using its length and not some random magic number. Fixes #356
Hi Thomas! Your fix in the ta/gh-356 allowed FvwmScript to go one step further: it opens FilePicker applet. Not it dies on SendToScript in widget 1. Binary in attachment, bt full below.
|
Core dump attachment. core.FvwmScript.1002.ee7a692e9e134ee7a9de16678e2acdb7.42470.1607967953000000.zip |
Not detailed ad Fedora, but here is the same thing from OpenBSD: coredumpctl debug 42470
Command Line: /opt/fvwm3/libexec/fvwm3/1.0.1/FvwmScript 47 4 none 0 8 FilePicker �12FvwmScript10
GNU gdb (GDB) Fedora 8.3.50.20190824-30.fc31 For help, type "help". |
Not such detailed as Fedora, but here is the same thing on OpenBSD. It coredumps every time.
|
Ensure the malloc()d space to the string is computed using its length and not some random magic number. Fixes #356
Here are differencies between ta/openbsd-fixes from Nov 30 2020 and current master in FvwmScript.c and Instructions.c:
|
Ensure the malloc()d space to the string is computed using its length and not some random magic number. Fixes #356
Hi, Please try again: |
You did it! |
Ensure the malloc()d space to the string is computed using its length and not some random magic number. Fixes #356
Hi Thomas, I've been a lot away from FVWM and NsCDE. Trying to catch what's going on this days. You just forced be to boot VMs of recent Fedora and FreeBSD and try my own TestScript. No signal 6, no core dump. This issue is definitely closed. |
Hi,
It is a bit of reworked clone of FvwmScript-FileBrowser used in NsCDE FVWM environment. Problem manifests only in FVWM3, and FVWM2 is ok. It can be reproduced on Fedora 33 and Fedora 31, but not on other systems.
This can be reproduced by opening NsCDE Style Manager, Backdrop Style Manager, and pushing "Add ..." button. FilePicker based on FvwmScript-FileBrowser will blink for a brief moment and core dump. This is in a way similar to the It is similar to #299 (For loop on Fedora 33 and FreeBSD). It works if called manually from FvwmCommand with "Module FvwmScript FilePicker".
I'm attaching FvwmScript binary and full backtrace from Fedora 31.
FvwmScript.zip
The text was updated successfully, but these errors were encountered: