Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmIconMan crashes when trying to display some utf-8 characters. #622

Closed
somiaj opened this issue Oct 15, 2021 · 7 comments
Closed

FvwmIconMan crashes when trying to display some utf-8 characters. #622

somiaj opened this issue Oct 15, 2021 · 7 comments
Labels
skip:changelog Issue/PR should skip CHANGELOG

Comments

@somiaj
Copy link
Collaborator

somiaj commented Oct 15, 2021

FvwmIconMan, using the default config, crashes when trying to display some utf-8 characters. For example the following character crashes FvwmIconMan

https://www.compart.com/en/unicode/U+1F479

With some further testing it is related to the font. The font from the default config is *FvwmIconMan: Font "xft:Sans:Bold:size=8:antialias=True". Setting the font to *FvwmIconMan: Font "", it no longer crashes and just displays a empty box for the character it cannot find. So this maybe a combination of the font and FvwmIconMan.

If possible, FvwmIconMan should better deal with some utf-8 characters in some fonts.

@somiaj somiaj added the type:bug Something's broken! label Oct 15, 2021
@ThomasAdam ThomasAdam added this to the 1.0.5 milestone Oct 15, 2021
@ThomasAdam
Copy link
Member

Hi @somiaj

Well... I can't get FvwmIconMan to crash.

Can you see if a corefile is generated, and add a backtrace so I can see what's happening?

@polarbub
Copy link

I tried to set the icon man font to "" and it did nothing for the problem.

This happens on the default config on 1.0.4 with the provided problem website.

@ThomasAdam
Copy link
Member

Hey @polarbub

I'll try and find time to look at this, but it won't be any time soon.

Do you see the same problem if you also try to start fvwm3 as:

fvwm3 -f /dev/null

@polarbub
Copy link

polarbub commented Feb 24, 2022

No, because no FvwmIconMan was started

@polarbub
Copy link

polarbub commented Feb 24, 2022

I tried to set the icon man font to "" and it did nothing for the problem.

I just restarted x and now this fix works. The charaters that would crash it before don't show up at all in the icon manager but the rest of the titles do. Also the font is the default font for x and it doesn't look very good.

topcat001 added a commit to topcat001/fvwm3 that referenced this issue Aug 2, 2022
Since we are rendering in only the chosen font, if the character in
question does not exist simply report its size as zero.

```
Fixes fvwmorg#622, fixes fvwmorg#680.
```
topcat001 added a commit to topcat001/fvwm3 that referenced this issue Aug 2, 2022
Since we are rendering in only the chosen font, if the character in
question does not exist simply report its size as zero.

```
Fixes fvwmorg#622, fixes fvwmorg#680.
```
@ThomasAdam ThomasAdam moved this to To do in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam removed this from the 1.0.5 milestone Sep 18, 2022
@somiaj
Copy link
Collaborator Author

somiaj commented Nov 6, 2022

This is actually an issue in XFT that was fixed three years ago, and merged 3 months ago.

https://gitlab.freedesktop.org/xorg/lib/libxft/-/commit/6a08279ee80dbd1a226592d7f18c862c2e4a7d3a

Upgrade to xft 2.3.6 to get color emoji's working correctly.

@somiaj somiaj closed this as completed Nov 6, 2022
Repository owner moved this from To do to Done in FVWM3 Nov 6, 2022
@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Nov 6, 2022
@somiaj somiaj removed the type:bug Something's broken! label Nov 6, 2022
@polarbub
Copy link

polarbub commented Nov 7, 2022

Alright, this works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG
Projects
Status: Done
Development

No branches or pull requests

3 participants