FvwmPager: CurrentDeskPerMonitor and two other features. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
added
type:enhancement
somiaj
force-pushed
the
js/pager-current-desktop
branch
2 times, most recently
from
e331142 to
931ce3c
Compare
This reverts commit f7aa753.
Add a new CurrentMonitor setting, which makes the pager only respond to the configured monitor when changing desks in both icon view and when viewing fAlwaysCurrentDesk is set. This makes what desk the pager is showing a bit less random in per-monitor mode.
This adds a configuration flag that can control how the pager shows windows when fAlwaysCurrentDesk is set, and this always affects the icon view. If CurrentDeskPerMonitor is set, and using per-monitor DesktopConfiguration, the pager will show the windows on the desk each monitor is on independently. This makes it so a single pager can control two monitors and their current independently.
This enables older code that would give focus to the window moved by the pager if the pager placed the window on the current desktop. This behavior is now disabled by default, and this option will enable the old behavior.
somiaj
force-pushed
the
js/pager-current-desktop
branch
from
58c4ade to
61f04c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following features to FvwmPager. Two features are fairly minor (so grouping them here) and the third is a new way to view the pager.
Add option
CurrentDeskPerMonitor. This option affects both the icon view of the pager and when the pager is tracking a current desk viafAlwaysCurrentDeskactivated by runningModule FvwmPager *. This option makes the pager show the windows on the current desktop of each monitor independently. Useful when usingper-monitorand the monitors are on different desks, to ensure you always see the windows for each monitor. In addition ifDeskLabelsandMonitorLabesare enabled, the desk that each monitor is currently viewing is shown in the label.Add option
FocusAfterMove. This option will useFlipFocuson any window that is moved by the pager and dropped in the current desktop of the monitor viewing the window. This is an old feature that was in the code, but was always enabled. Not all use cases would want this feature, so instead I disabled it by default, and added this new option to turn it on.Add option
CurrentMonitor RandRname. This option configures acurrent_monitorthat is used to determine when the current desktop should update. Without setting this option, the current desktop for icon view, or when using the pager infAlwaysCurrentDesk, modeModule FvwmPager *, is updated each and every time any monitor changes desktops. This may not be ideal inper-monitormode, so configuring this option will make the current desktop only update when the specified monitor changes desktops, and ignore all other monitors.