FvwmPager: Make mouse bindings configurable. #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
added
type:enhancement
|
Hi, This looks fine to me. I've only focused on the commit "add mouse binding configuration" as the other commits have already been merged. Very minor typo, but might as will fix as this PR will need rebasing anyway, before it can be merged. |
somiaj
force-pushed
the
js/pager-mouse-bindings
branch
3 times, most recently
from
757af02 to
7460e5e
Compare
Instead of FvwmPager's mouse bindings being hard coded, these can now be configured using the `Mouse <N> Action command` option. The bindings can do all the same tasks as before. They can change the current desk/page, move windows, and scroll. In addition custom commands can be sent to windows instead of just `FlipFocus`. Only the primary mouse buttons, 1-5, are supported, but this gives a little more control over what the mouse buttons do.
somiaj
force-pushed
the
js/pager-mouse-bindings
branch
from
7460e5e to
14e81a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the mouse bindings being hard coded (mouse 1 changes desk/page, 2 focus/moves windows, and 3 scroll), this adds support to configure what the bindings do and supports the primary mouse buttons 1-5 only (no extended mouse buttons).
The bindings can be used to disable or move which button any of the default bindings are on, or add custom commands to send to fvwm/windows. One example is one could make the mouse wheel (buttons 4 and 5) change the current desk, so using the mouse wheel on the pager will cycle through desktops (could be useful with the always show current desk pager). You can also make bindings that act on the window you click on, so you could maximize, iconify, shade, or run any custom fvwm function on the window clicked.
The bindings are configured using the following:
This is built on top of #1015, so that will need to be merged first.