Use Kotlin DSL for gradle scripts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I say we merge this now. Then people can try building themselves and maybe create PRs with solutions to what I wrote in the description 🙂 Closes #74. (hopefully) |
fwcd
reviewed
Jan 26, 2024
Comment on lines
+28
to
+30
| // modules temporarily needed because of shared module import above | ||
| implementation("org.jetbrains.exposed:exposed-core:0.37.3") | ||
| implementation("org.jetbrains.exposed:exposed-dao:0.37.3") |
There was a problem hiding this comment.
The classpath database machinery would probably be interesting for the debug adapter too, perhaps we can integrate that permanently here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sharing of code from the shared module in kotlin-language-server started failing roughly at the time we set up Kotlin DSL there. (issue: #74). This PR makes it possible to use the latest shared module again.
Probably not perfect, but seems to create the necessary artifacts (i.e, zip file and executables).
About the inclusion of the exposed dependencies:
If we don't add this, while still using newest kotlin-language-server:shared, we get the following error:
Adding the dependencies fixes the issue. We should find a way to avoid adding them here, as the versions might deviate between this project and kotlin-language-server. It seems like the shared module don't read the versions from its platform module when importing it like we do in this project. We might start by looking into that.