Fix maven repository discovery #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the maven repository discovery by checking if the candidate paths have a `/repository` directory. An exception is thrown if no valid repository paths are found.
themkat
approved these changes
Oct 15, 2023
fwcd
reviewed
Oct 18, 2023
fwcd
reviewed
Oct 18, 2023
Reformat single expression `createPathOrNull` function. Co-authored-by: fwcd <[email protected]>
Co-authored-by: fwcd <[email protected]>
|
Ok cool. I'll let you guys squash when merging then 👍 |
|
All PR comments seems to be resolved, so merging. Thank you @calamont ! 😄 |
fwcd
reviewed
Jul 28, 2024
Comment on lines
+22
to
+24
| ?: throw KotlinLSException( | ||
| "No repositories found at \$MAVEN_REPOSITORY, \$MAVEN_HOME, \$M2_HOME or \$HOME/.m2" | ||
| ) |
There was a problem hiding this comment.
I think the exception might have broken all clients that didn't have a Maven repository (e.g. #564). We should really be a bit more careful with silently changing the type of something, this had to be optional for the class path resolver logic to work properly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #430
Fixes the Maven repository discovery by checking if the candidate paths have a
/repositorydirectory. An exception is thrown if no valid repository paths are found. The order of discovery is maintained as before:$MAVEN_REPOSITORY$MAVEN_HOME$M2_HOME$HOME/.m2