Refactor map encoding to prep for Go version bump #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor helps reduce duplicate code in upcoming PRs.
8 tasks
|
@dinhxuanvu @x448 Please take a look and let me know if you approve or if changes are needed. I'd like to merge this PR so PR #468 can take advantage of this and get merged too. Thanks! |
x448
approved these changes
Jan 22, 2024
fxamacker
deleted the
fxamacker/refactor-map-encode-to-prepare-for-go-verion-bump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor old map encoding code to prep for Go version bump and reduce duplicate code required by upcoming PRs.
@dinhxuanvu opened issue and PR that shows impressive results 🎉 (both speedup & memory reduction!):
This PR refactors old code related to map encoding, so new PRs like #468 won't require as much duplicate code.