-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TruffleRuby in CI #305
Conversation
* We need to use truffleruby-head for now because of oracle/truffleruby#3683
Awesome, thanks @eregon! |
@@ -16,7 +16,11 @@ jobs: | |||
ruby-version: | |||
- "3.2" | |||
- "3.3" | |||
- "truffleruby-head" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could now add or switch to truffleruby-24.1.2 in CI, e.g. with "truffleruby"
(latest release), WDYT @fxn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for addressing that!
I created #311 but some tests are failing, maybe give it a time for packages to be available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, https://github.com/ruby/setup-ruby/actions/runs/12989568868 was 33min ago and your PR 34min ago so probably just a bit too fast, could you rerun the CI on that PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greener! There's just one failure on Windows, error says is is unsupported. Should we remove that pair from the matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the error is accurate, so that combination should be excluded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, thanks @eregon!
Now all tests pass, except oracle/truffleruby#2431 for well-known reasons.
I would like to add TruffleRuby in CI so it's easy to notice any potential issue going forward.