Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TruffleRuby in CI #305

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add TruffleRuby in CI #305

merged 3 commits into from
Oct 18, 2024

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Oct 18, 2024

Now all tests pass, except oracle/truffleruby#2431 for well-known reasons.

I would like to add TruffleRuby in CI so it's easy to notice any potential issue going forward.

@fxn
Copy link
Owner

fxn commented Oct 18, 2024

Awesome, thanks @eregon!

@fxn fxn merged commit 0be1875 into fxn:main Oct 18, 2024
11 checks passed
@@ -16,7 +16,11 @@ jobs:
ruby-version:
- "3.2"
- "3.3"
- "truffleruby-head"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could now add or switch to truffleruby-24.1.2 in CI, e.g. with "truffleruby" (latest release), WDYT @fxn ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for addressing that!

I created #311 but some tests are failing, maybe give it a time for packages to be available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, https://github.com/ruby/setup-ruby/actions/runs/12989568868 was 33min ago and your PR 34min ago so probably just a bit too fast, could you rerun the CI on that PR?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greener! There's just one failure on Windows, error says is is unsupported. Should we remove that pair from the matrix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the error is accurate, so that combination should be excluded

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, thanks @eregon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants