Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace redact-ID with RedactAction #102

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

cdoron
Copy link
Collaborator

@cdoron cdoron commented Oct 20, 2021

and the same for removed-ID

Signed-off-by: Doron Chen [email protected]

and the same for removed-ID

Signed-off-by: Doron Chen <[email protected]>
@cdoron cdoron requested review from shlomitk1 and ritwikc October 20, 2021 10:19
@roee88 roee88 merged commit ded4891 into master Oct 20, 2021
@@ -32,10 +32,10 @@ data:
{{- $redactColumns := list -}}
{{- $removeColumns := list -}}
{{- range .transformations -}}
{{- if eq .id "redact-ID" -}}
{{- if eq .id "RedactAction" -}}
{{- $redactColumns = append $redactColumns .args.column_name -}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdoron Sorry merged by accident.

  1. .id: I think it should be .action.name
  2. .args.column_name; I think it should be .action.RedactAction.columns

@ritwikc can verify

Copy link
Collaborator

@ritwikc ritwikc Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's the change needed.

@roee88 roee88 deleted the replace-redact-ID-with-RedactAction branch October 20, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants