Add a workflow to test the module. #121
Conversation
Signed-off-by: nassarmu10 <[email protected]>
hack/tools/test_module.sh
Outdated
|
|
||
| bin/helm install cert-manager jetstack/cert-manager \ | ||
| --namespace cert-manager \ | ||
| --version v1.2.0 \ |
There was a problem hiding this comment.
Please use certManagerVersion
.github/workflows/test-module.yaml
Outdated
| default: '0.6.0' | ||
| module-type: | ||
| required: true | ||
| default: 'stream' |
There was a problem hiding this comment.
module-type is not need here
hack/tools/test_module.sh
Outdated
| kubernetesVersion=$1 | ||
| fybrikVersion=$2 | ||
| moduleVersion=$3 | ||
| module=$4 |
There was a problem hiding this comment.
Please remove module and add moduleResourceVersion as in https://github.com/fybrik/data-movement-operator/blob/master/hack/tools/test_module.sh#L19 to support module patched version.
|
|
||
|
|
||
| bin/kubectl apply -f $WORKING_DIR/fybrikapplication-$moduleVersion.yaml | ||
|
|
There was a problem hiding this comment.
Please use moduleResourceVersion instead of moduleVersion
hack/tools/test_module.sh
Outdated
|
|
||
|
|
||
|
|
||
| bin/kubectl -n fybrik-system create configmap sample-policy --from-file=$WORKING_DIR/sample-policy-$moduleVersion.rego |
There was a problem hiding this comment.
Please use moduleResourceVersion instead of moduleVersion
| @@ -0,0 +1,10 @@ | |||
| apiVersion: app.fybrik.io/v1alpha1 | |||
There was a problem hiding this comment.
This file is not need for the test
| @@ -0,0 +1,10 @@ | |||
| apiVersion: app.fybrik.io/v1alpha1 | |||
There was a problem hiding this comment.
This file is not need for the test
hack/make-rules/tools.mk
Outdated
| $(TOOLBIN)/yq: | ||
| cd $(TOOLS_DIR); ./install_yq.sh | ||
| $(call post-install-check) |
There was a problem hiding this comment.
The call to post-install-check is not needed here (post-install-check is not present in this file and its also checks go functions)
hack/make-rules/tools.mk
Outdated
| $(TOOLBIN)/helm: | ||
| cd $(TOOLS_DIR); ./install_helm.sh | ||
| $(call post-install-check) |
There was a problem hiding this comment.
The call to post-install-check is not needed here (post-install-check is not present in this file and its also checks go functions)
| $(TOOLBIN)/kind: | ||
| GOBIN=$(ABSTOOLBIN) go install sigs.k8s.io/[email protected] | ||
| $(call post-install-check) | ||
|
|
| $(TOOLBIN)/kubebuilder $(TOOLBIN)/etcd $(TOOLBIN)/kube-apiserver $(TOOLBIN)/kubectl: | ||
| cd $(TOOLS_DIR); ./install_kubebuilder.sh | ||
| $(call post-install-check) | ||
|
|
Signed-off-by: nassarmu10 <[email protected]>
Signed-off-by: nassarmu10 [email protected]