Support "append" write mode. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Sur <[email protected]> Co-authored-by: Mohammad Nassar <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
|
@cdoron I addressed your comments. Thanks |
Mohammad-nassar10
approved these changes
Mar 31, 2022
cdoron
approved these changes
Mar 31, 2022
afm/server.py
Outdated
| ds.write_dataset(transformed_batches, base_dir=asset.path, basename_template="part-{:%Y-%m-%d-%H-%M-%S-%f}-{{i}}.parquet".format(datetime.datetime.now()), format=asset.format, filesystem=asset.filesystem, existing_data_behavior='overwrite_or_ignore') | ||
| else: | ||
| logger.trace("write_mode: overwrite", extra={DataSetID: asset.name, ForUser: True}) | ||
| ds.write_dataset(transformed_batches, base_dir=asset.path, basename_template="part-{:%Y-%m-%d-%H-%M-%S-%f}-{{i}}.parquet".format(datetime.datetime.now()), format=asset.format, filesystem=asset.filesystem, existing_data_behavior='delete_matching') |
There was a problem hiding this comment.
lines 71-71 are almost identical to 73-74. Try to merge them
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
Closes #152
This PR support
appendwrite mode. The default write mode isoverwrite.In addition, arrow flight version is upgraded to v7 to support writing csv files.
Signed-off-by: Revital Sur [email protected]
Co-authored-by: Mohammad Nassar [email protected]