HashRedact #59
Merged
HashRedact #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he required columns to the hexa representation of the hash value that returned from the python built-in hash() function. Signed-off-by: Mohammad Nassar <[email protected]>
Mohammad-nassar10
changed the title
|
@Mohammad-nassar10 a PR should always be linked with an issue. |
|
@ronenkat I added an issue, can you please check it? |
Signed-off-by: Mohammad Nassar <[email protected]>
cdoron
approved these changes
Apr 1, 2021
ronenkat
reviewed
May 3, 2021
afm/pep/actions.py
Outdated
| hashFunc = hashlib.md5 | ||
| if algo == "md5": | ||
| hashFunc = hashlib.md5 | ||
| elif algo == "sha1": |
There was a problem hiding this comment.
please replace SHA1 with SHA256 and SHA512, suggest we support both.
ronenkat
reviewed
May 3, 2021
Signed-off-by: Mohammad-nassar10 <[email protected]>
Adding sha256 and sha512 to hash redact.
dopefermer123
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new method of transformation, where changing each value in the required columns to the hexa representation of the hash value that returned from the python built-in hash() function.
Signed-off-by: Mohammad Nassar [email protected]