OpenMetadata install script #1731
Conversation
Signed-off-by: Doron Chen <[email protected]>
Signed-off-by: Doron Chen <[email protected]>
Signed-off-by: Doron Chen <[email protected]>
Signed-off-by: Doron Chen <[email protected]>
| @@ -0,0 +1,17 @@ | |||
| // Copyright 2020 IBM Corp. | |||
There was a problem hiding this comment.
why do you need this start connector here ?
There was a problem hiding this comment.
The NewOpenMetadataAPIService() method runs a prepareOpenMetadataForFybrik() method which creates the custom properties that we need.
There was a problem hiding this comment.
I removed the go code.
The preparation is now done using the same executable as that of the openmetadata-connector (with different parameters).
|
|
||
| func main() { | ||
| conf := map[interface{}]interface{}{ | ||
| "openmetadata_endpoint": "http://localhost:8585/api", |
There was a problem hiding this comment.
can it be an argument or env parameter
There was a problem hiding this comment.
The preparation code gets the endpoint, username, and password from an environment variable.
| "openmetadata_endpoint": "http://localhost:8585/api", | ||
| } | ||
| logger := logging.LogInit(logging.CONNECTOR, "OpenMetadata Prepare for Fybrik") | ||
| openapi_connector_core.NewOpenMetadataAPIService(conf, &logger) |
There was a problem hiding this comment.
can we separate the connection and tag creation from NewOpenMetadataAPI Service creation, and get the custom properties and tags from external files
Signed-off-by: Doron Chen <[email protected]>
Signed-off-by: Doron Chen <[email protected]>
Signed-off-by: Doron Chen <[email protected]>
| export OPENMETADATA_HELM_CHART_VERSION=0.0.39 | ||
|
|
||
| export FYBRIK_BRANCH="${FYBRIK_BRANCH:-master}" | ||
| export FYBRIK_GITHUB_ORGANIZATION="${FYBRIK_NAMESPACE:-fybrik}" |
There was a problem hiding this comment.
${FYBRIK_NAMESPACE:-fybrik} -> ${FYBRIK_GITHUB_ORGANIZATION:-fybrik}
Signed-off-by: Doron Chen <[email protected]>
No description provided.