Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-omd-discover-s3-asset.md to reflect #1818

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

cdoron
Copy link
Collaborator

@cdoron cdoron commented Nov 20, 2022

that some of the Custom Properties have been
removed.
Also, the default tag category is now GenericTags
(replacing Fybrik)

Signed-off-by: Doron Chen [email protected]

that some of the Custom Properties have been
removed.
Also, the default tag category is now GenericTags
(replacing Fybrik)

Signed-off-by: Doron Chen <[email protected]>
@cdoron cdoron requested review from simanadler and roytman November 20, 2022 10:38
1. Register an asset through the OpenMetadata UI
2. Registering Dataset via Connector

Signed-off-by: Doron Chen <[email protected]>
Copy link
Collaborator

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the pictures you continue to use GenericTags, and you have GenericTags.PII and PII.Sensitive

Store the asset ID in a `CATALOGED_ASSET` variable:
```bash
CATALOGED_ASSET="openmetadata-s3.default.demo.\"PS_20174392719_1491204439457_log.csv\""
```

The asset is now registered in the catalog.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the OPA policies examples below are not updated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we should address this in a different PR. I could work on it tomorrow morning.

<br><center><img src="../../static/openmetadata/18_table_name.jpg" width=600></center>
1. Choose a tag for the dataset, such as `Fybrik.finance`
1. Choose a tag for the dataset, such as `GenericTags.finance`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe Purpose.finance

@roytman roytman enabled auto-merge (squash) November 21, 2022 19:31
@roytman roytman merged commit 13a60bd into fybrik:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants