Feature/kubernetes #108
Closed
Feature/kubernetes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metal3d I couldn't add you as a reviewer, but if you do have some time have a look. |
|
We can't use |
Oh, I was wondering what was that error. Thanks, will fix. |
added 14 commits
April 14, 2022 12:55
Bluebugs
force-pushed
the
feature/kubernetes
branch
from
3d20573 to
9dc5d3c
Compare
|
Closing this PR as the amount of change after the refactoring PR land is going to be really massive and make this harder to understand. Will do a clean PR on top of the refactoring PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This add a working Kubernetes support for fyne-cross. It does use S3 to upload/download information out of the container/pod. The pod run for ever using a sleep infinite (I think we could hard code a limit there of maybe 30min?). Kubernetes exec command are used to execute command inside the pod. For most case, we do not need to change directory, but when we do I have to add a shell command to solve this problem.
I have moved a few operation that where done on the host, but relied on the file being local to be inside the pod (zip, move, copy). I haven't figured out how to handle the case when no Icon is provided at the moment.
I still need to do extensive testing with this patch (with kubernetes and without), but I wanted to start getting people review as early as possible.
Fixes #98
Checklist:
Where applicable:
go mod vendor).