Feature/kubernetes

[Bluebugs]

Description:

This does add a Kubernetes engine to fyne-cross.

Fixes #98

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style.
• Any breaking changes have a deprecation path or have been discussed.
• Updated the vendor folder (using go mod vendor).

[andydotxyz]

Can you address the test failures @Bluebugs , then we can do a full review?

[Bluebugs]

Can you address the test failures @Bluebugs , then we can do a full review?

Yes, the issue is due to a dependency that doesn't support old go. Need to use a less nice API to work around it :-(

[Bluebugs]

I just noticed something, I can't find the code for fyne-cross-s3. It somehow disappeared. Will look into it tomorrow.

[Jacalz]

Looking at the use of archiver and problems with Go 1.14 compilation, it might even make sense to not use it at all and just create the functionality ourselves. It is a big modules because it imports all of the code for the compression formats it support.

I have some tar compression code laying around in a private repo if you are interested.

[Bluebugs]

@Jacalz I think it would be better not to, as that is technical debt that we have to carry and there is already a lot to care for.

[Bluebugs]

Finally got all the dependencies right! So conclusion of this experiment, the sub directory with go.mod does work. It will do a full download of all the dependencies and build (like a vendor directory) for all go version below 1.16. This mean that for the folks below 1.16, they will still download the kubernetes dependencies when building fyne-cross with this change. For anyone with a more recent go, it will not.

If that is not acceptable, the next logical step, is to make a child process to insulate the dependencies. This would also make it possible to use more recent dependencies for the independent command as it would not be included at all included in older version.

[Bluebugs]

I have come across a problem with go install and the replace directive. The go.mod in this PR work fine with older go get and go build/go install, but not with a remote url passed to go install. The bug is described here: golang/go#44840 . It does seems there is no interest in solving this issue in go at this point. The problem can be solved by having a custom go run command that would do all the installation step that a go install should do or with a binary that has to be compiled separately.

I like the idea of the go run command as we can start checking the environment for having a proper setup to run fyne-cross, but I would understand that we prefer to just support go install command and I can look into using a separate process. Let me know which direction you would be interested in.

[andydotxyz]

So cool, a couple of notes about parameters and error handling.

Changes in, thanks :)

[andydotxyz]

Looks good to me, but will leave it to someone closer to the project to 👍

[lucor]

I have come across a problem with go install and the replace directive. The go.mod in this PR work fine with older go get and go build/go install, but not with a remote url passed to go install. The bug is described here: golang/go#44dis840 . It does seems there is no interest in solving this issue in go at this point. The problem can be solved by having a custom go run command that would do all the installation step that a go install should do or with a binary that has to be compiled separately.

I like the idea of the go run command as we can start checking the environment for having a proper setup to run fyne-cross, but I would understand that we prefer to just support go install command and I can look into using a separate process. Let me know which direction you would be interested in.

As discussed in the slack channel, it is probably good enough for now having it as is, once we have documented the installation behaviour in the README. After that I think the PR is ready to be merged 👍

[andydotxyz]

Well done, this has been a long haul!