Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ldflags where only needed with older version of zig which we have updated since then. #246

Merged
merged 1 commit into from
May 29, 2024
Merged

Ldflags where only needed with older version of zig which we have updated since then. #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions internal/command/darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ func (cmd *darwin) setupContainerImages(flags *darwinFlags, args []string) error
return fmt.Errorf("could not make command context for %s OS: %s", darwinOS, err)
}

flags.Ldflags += " -s -w"

ctx, err := makeDefaultContext(flags.CommonFlags, args)
if err != nil {
return err
Expand All @@ -200,7 +198,7 @@ func (cmd *darwin) setupContainerImages(flags *darwinFlags, args []string) error

ctx.Category = flags.Category

// Following settings are needed to cross compile with zig 0.9.1
// Following settings are needed to cross compile with zig
ctx.BuildMode = "pie"

cmd.defaultContext = ctx
Expand Down
Loading