Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker/android] Update to use the latest command line tools and updates the Android builds to SDK 30 #63

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

lucor
Copy link
Member

@lucor lucor commented Aug 19, 2021

This PR updates the android docker image to use the latest command line tools and updates the Android builds to SDK 30

@lucor lucor changed the base branch from master to develop August 19, 2021 10:11
@lucor lucor requested review from Jacalz and andydotxyz August 19, 2021 10:11
@Jacalz
Copy link
Member

Jacalz commented Aug 19, 2021

I'm wondering if we perhaps should wait a little bit more before jumping onto 1.17. Not that I have used it yet and/or found any breaking bugs, but it might be worth waiting for one or two bug fixes before we make the change. It also lets the rest of the ecosystem catch up a bit (if it needs to).

It would also be nice if we could get Windows/arm64 support in but I don't have any machine to run that so I'll not personally shout it out as a priority :)

andydotxyz
andydotxyz previously approved these changes Aug 19, 2021
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Jacob's point is a good one

@lucor
Copy link
Member Author

lucor commented Aug 19, 2021

@Jacalz it is a good point. Yes, the idea was to add support for windows/arm64 as well but let's remove the Go 1.17 update from this PR (done in 0615997) and handle later with a dedicated one :)

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@lucor lucor merged commit 6b4bc88 into fyne-io:develop Aug 19, 2021
@lucor lucor deleted the feature/docker-go-1.17-android-30 branch August 19, 2021 18:23
@lucor lucor changed the title Update docker images: Go v1.17 and Android builds SDK 30 [docker/image] Update to use the latest command line tools and updates the Android builds to SDK 30 Aug 19, 2021
@lucor lucor changed the title [docker/image] Update to use the latest command line tools and updates the Android builds to SDK 30 [docker/android] Update to use the latest command line tools and updates the Android builds to SDK 30 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants