Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes darwin image creation (SDK extraction) #80

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

alexadhy
Copy link
Contributor

@alexadhy alexadhy commented Oct 7, 2021

Description:

Fixes darwin image creation (SDK is using xz instead of bz2 compression)

Checklist:

  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member

Maybe it should somehow be .tar.* so it supports both formats? (Assuming it changed recently and users may be downloading both?).
It would be a more complicated change but feels more complete.

@alexadhy
Copy link
Contributor Author

alexadhy commented Oct 7, 2021

cool, alright . Done.

@lucor
Copy link
Member

lucor commented Oct 7, 2021

Thanks @alexadhy. LGTM just a little small thing before merge it.
Starting from v1.1.x the darwin image can be also generated using fyne-cross. To achieve this the darwin/Dockerfile is embedded using the make embed task.
Do you mind to run the make embed task and commit the generated resource/darwin_dockerfile.go file ?

@lucor
Copy link
Member

lucor commented Oct 7, 2021

Nevermind it was already there :)

@lucor lucor merged commit 969af58 into fyne-io:develop Oct 7, 2021
@Jacalz Jacalz mentioned this pull request Nov 2, 2021
@lucor lucor mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants