Release 1.2.0 #90

lucor · 2022-02-13T19:00:50Z

Description:

This branch contains the updates for develop in order to release v1.2.0

Checklist:

Tests included.
Lint and formatter run with no errors.
Tests all pass.

Where applicable:

Public APIs match existing style.
Any breaking changes have a deprecation path or have been discussed.

andydotxyz · 2022-02-13T22:21:51Z

Weird that I can't see the reason for the command test to fail...?

Also, should we hold back for the (planned) v2.1.3 in a week or so?

This commit update the isEngineDocker logic for the alias detection looking at the docker --version output. This will prevent to search into the docker binary for the podman string match

lucor · 2022-02-20T19:37:24Z

As discussed on slack this PR will be marked as ready for review once fyne 2.1.3 will be released in a week or so.
In the meantime to test this branch and the develop one the following docker images have been published on docker hub:

1.1-android-22.02.20
1.1-base-22.02.20
1.1-base-freebsd-22.02.20
1.1-base-llvm-22.02.20
1.1-freebsd-amd64-22.02.20
1.1-freebsd-arm64-22.02.20
1.1-linux-386-22.02.20
1.1-linux-arm-22.02.20
1.1-linux-arm64-22.02.20
1.1-windows-22.02.20

Fixes: fyne-io#41

Jacalz · 2022-02-28T19:47:08Z

Nice work on this. I'll make sure to review it towards the end of the week :)

lucor · 2022-02-28T21:34:35Z

Need to fix some unit tests related to podman and flag order, but it should be ready for testing.
The images are now tagged as 1.2:

1.2-android
1.2-base
1.2-freebsd-amd64
1.2-freebsd-arm64
1.2-linux-386
1.2-linux-arm
1.2-linux-arm64
1.2-windows
1.2-android-22.02.28
1.2-base-22.02.28
1.2-freebsd-amd64-22.02.28
1.2-freebsd-arm64-22.02.28
1.2-linux-386-22.02.28
1.2-linux-arm-22.02.28
1.2-linux-arm64-22.02.28
1.2-windows-22.02.28

Jacalz · 2022-03-04T20:58:58Z

@lucor Have you managed to dig into why the CI tests are failing?

Jacalz

Two notes about things that I think we might want to do before we release this:

Update to the Go release for a security fix.
Update https://github.com/BurntSushi/toml to v1.0.0.

Jacalz · 2022-03-04T21:06:15Z

I am getting this error when I try to build using podman:

~/go/bin/fyne-cross linux -arch amd64,arm64
[i] Target: linux/amd64
[i] Cleaning target directories...
[✓] "bin" dir cleaned: /home/jacob/Git/wormhole-gui/fyne-cross/bin/linux-amd64
[✓] "dist" dir cleaned: /home/jacob/Git/wormhole-gui/fyne-cross/dist/linux-amd64
[✓] "temp" dir cleaned: /home/jacob/Git/wormhole-gui/fyne-cross/tmp/linux-amd64
[i] Checking for go.mod: /home/jacob/Git/wormhole-gui/go.mod
[✓] go.mod found
[i] Building binary...
Error: short-name resolution enforced but cannot prompt without a TTY
[✗] exit status 125

lucor · 2022-03-05T18:04:31Z

46d31fb updates Go to v1.17.8
67b06a9 updates dependencies
186976b fixes docker image short-name resolution error
11777ed and 2381faf fix the unit tests.

New images are published on docker hub for testing:

1.2-android
1.2-base
1.2-freebsd-amd64
1.2-freebsd-arm64
1.2-linux-386
1.2-linux-arm
1.2-linux-arm64
1.2-windows
1.2-android-22.03.05
1.2-base-22.03.05
1.2-freebsd-amd64-22.03.05
1.2-freebsd-arm64-22.03.05
1.2-linux-386-22.03.05
1.2-linux-arm-22.03.05
1.2-linux-arm64-22.03.05
1.2-windows-22.03.05

Jacalz

This is so very close now! You are doing some amazing work, as usual :)
I managed to build Windows amd64, FreeBSD and Linux (amd64 and arm64) without any issues at all.

I ran into one small snag though, and that is that the darwin-image command still expects docker to be installed. I get this error message:

[jacob@vostro Downloads]$ ~/go/bin/fyne-cross darwin-image -xcode-path Command_Line_Tools_for_Xcode_13.2.dmg
[i] Building docker darwin image...
[i] Work dir: /tmp/fyne-cross-darwin-build385098383
[i] Copying the Command Line Tools for Xcode from Command_Line_Tools_for_Xcode_13.2.dmg to /tmp/fyne-cross-darwin-build385098383/command_line_tools_for_xcode.dmg...
[✓] Command Line Tools for Xcode copied
[✓] Dockerfile created
[i] Building docker image...
[i] macOS SDK: auto
[✗] could not create the docker darwin image: exec: "docker": executable file not found in $PATH

Jacalz

I'm running into this error again (but now when building the image):

~/go/bin/fyne-cross darwin-image -xcode-path Command_Line_Tools_for_Xcode_13.2.dmg
[i] Building docker darwin image...
[i] Work dir: /tmp/fyne-cross-darwin-build906248948
[i] Copying the Command Line Tools for Xcode from Command_Line_Tools_for_Xcode_13.2.dmg to /tmp/fyne-cross-darwin-build906248948/command_line_tools_for_xcode.dmg...
[✓] Command Line Tools for Xcode copied
[✓] Dockerfile created
[i] Building docker image...
[i] macOS SDK: auto
[1/2] STEP 1/11: FROM fyneio/fyne-cross:1.2-base-llvm AS osxcross
[2/2] STEP 1/3: FROM fyneio/fyne-cross:1.2-base-llvm
Error: error creating build container: short-name resolution enforced but cannot prompt without a TTY
[✗] could not create the docker darwin image: exit status 125

lucor · 2022-03-06T19:07:45Z

The image name needs to be in long format (i.e. docker.io/fyneio/fyne-cross) otherwise podman will prompt for a registry to download from unless not specified in the configuration.
We run all the docker commands without the TTY attached hence the error.
Fixed in e92345d

Jacalz

Worked flawlessly. Nice work!

I couldn't get it to build when using -tags legacy for my darwin builds but that is not something that is part of this PR directly, so I'll approve this :)

Jacalz

Looks like I may have jumped the gun there. The build of amd64 had failed but not with a return code that made everything else fail. I'll look into it and see if an older SDK makes any difference.

# fyne.io/fyne/v2/app
app_darwin.m:17:25: warning: 'UNUserNotificationCenter' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNUserNotificationCenter.h:38:12: note: 'UNUserNotificationCenter' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:17:6: note: annotate 'doSendNotification' with an availability attribute to silence this warning
app_darwin.m:18:5: warning: 'UNMutableNotificationContent' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationContent.h:63:12: note: 'UNMutableNotificationContent' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:18:5: note: enclose 'UNMutableNotificationContent' in an @available check to silence this warning
app_darwin.m:18:46: warning: 'UNMutableNotificationContent' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationContent.h:63:12: note: 'UNMutableNotificationContent' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:18:46: note: enclose 'UNMutableNotificationContent' in an @available check to silence this warning
app_darwin.m:25:5: warning: 'UNNotificationRequest' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationRequest.h:16:12: note: 'UNNotificationRequest' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:25:5: note: enclose 'UNNotificationRequest' in an @available check to silence this warning
app_darwin.m:25:39: warning: 'UNNotificationRequest' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationRequest.h:16:12: note: 'UNNotificationRequest' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:25:39: note: enclose 'UNNotificationRequest' in an @available check to silence this warning
app_darwin.m:36:5: warning: 'UNUserNotificationCenter' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNUserNotificationCenter.h:38:12: note: 'UNUserNotificationCenter' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:36:5: note: enclose 'UNUserNotificationCenter' in an @available check to silence this warning
app_darwin.m:36:41: warning: 'UNUserNotificationCenter' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNUserNotificationCenter.h:38:12: note: 'UNUserNotificationCenter' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:36:41: note: enclose 'UNUserNotificationCenter' in an @available check to silence this warning
app_darwin.m:40:5: warning: 'UNAuthorizationOptions' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNUserNotificationCenter.h:22:32: note: 'UNAuthorizationOptions' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:40:5: note: enclose 'UNAuthorizationOptions' in an @available check to silence this warning
app_darwin.m:40:38: warning: 'UNAuthorizationOptionAlert' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/osxcross/target/bin/../SDK/MacOSX11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNUserNotificationCenter.h:22:32: note: 'UNAuthorizationOptions' has been marked as being introduced in macOS 10.14 here, but the deployment target is macOS 10.12.0
app_darwin.m:40:38: note: enclose 'UNAuthorizationOptionAlert' in an @available check to silence this warning

Jacalz · 2022-03-07T15:51:20Z

That was with 13.2 SDK. I'm rebuilding the image with forcing the 11.3 SDK to be used. If that doesn't work, I'll try to drop down to 12.4 and see if that makes any difference.

Jacalz

Looks like forcing the -std-version worked perfectly. Sorry for the fuzz.

lucor · 2022-03-07T17:23:31Z

Glad it worked, thanks for testing @Jacalz

lucor changed the base branch from master to develop February 13, 2022 19:01

Jacalz self-requested a review February 19, 2022 12:53

lucor added 7 commits February 20, 2022 18:51

chnagelog: update

faea17a

test: update unit tests

2c1466a

linter: fix linter suggestions

9330471

revert to use execabs

86ad8f4

docker: update to check for an alias looking at the version output

2c5973f

This commit update the isEngineDocker logic for the alias detection looking at the docker --version output. This will prevent to search into the docker binary for the podman string match

changelog: update

8f08515

test: fix engine binary lookup

4c947bc

lucor force-pushed the 1.2.0 branch from 8f250e8 to 4c947bc Compare February 20, 2022 17:53

test: skip if engine does not exist on host

4519a4a

lucor force-pushed the 1.2.0 branch from 70cffc2 to 4519a4a Compare February 20, 2022 18:16

lucor mentioned this pull request Feb 20, 2022

Doesn't work with podman (docker-podman) because of write persmission #41

Closed

lucor added 4 commits February 28, 2022 20:12

base image: update fyne to v2.1.3

3dd3ef4

base image: update to use fixuid

533bb1c

Fixes: fyne-io#41

docker images: bump version to 1.2

85f2100

base image: fix fixuid installation

28281bc

Jacalz requested changes Mar 4, 2022

View reviewed changes

lucor added 5 commits March 5, 2022 16:15

fix: docker image short-name resolution error

186976b

base image: update Go to v1.17.8

46d31fb

deps: update BurntSushi/toml and stretchr/testify

67b06a9

test: fix unit tests for the podman engine

11777ed

test: update unit tests for docker on windows

2381faf

lucor requested a review from Jacalz March 5, 2022 18:04

lucor mentioned this pull request Mar 5, 2022

Add support for FyneApp.toml #78

Closed

Jacalz requested changes Mar 5, 2022

View reviewed changes

This comment was marked as off-topic.

Sign in to view

command/darwin_image: fix hardcoded docker binary

efb6fa3

Jacalz requested changes Mar 6, 2022

View reviewed changes

darwin_docker: fix image short-name resolution error for podman

e92345d

lucor marked this pull request as ready for review March 6, 2022 19:07

lucor requested a review from Jacalz March 6, 2022 19:08

Jacalz approved these changes Mar 7, 2022

View reviewed changes

Jacalz requested changes Mar 7, 2022

View reviewed changes

Jacalz approved these changes Mar 7, 2022

View reviewed changes

lucor merged commit 2f14765 into fyne-io:develop Mar 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.2.0 #90

Release 1.2.0 #90

lucor commented Feb 13, 2022

andydotxyz commented Feb 13, 2022

lucor commented Feb 20, 2022

Jacalz commented Feb 28, 2022

lucor commented Feb 28, 2022

Jacalz commented Mar 4, 2022

Jacalz left a comment

Jacalz commented Mar 4, 2022

lucor commented Mar 5, 2022 •

edited

Loading

Jacalz left a comment

This comment was marked as off-topic.

Jacalz left a comment

lucor commented Mar 6, 2022

Jacalz left a comment

Jacalz left a comment •

edited

Loading

Jacalz commented Mar 7, 2022 •

edited

Loading

Jacalz left a comment

lucor commented Mar 7, 2022

Release 1.2.0 #90

Release 1.2.0 #90

Conversation

lucor commented Feb 13, 2022

Description:

Checklist:

Where applicable:

andydotxyz commented Feb 13, 2022

lucor commented Feb 20, 2022

Jacalz commented Feb 28, 2022

lucor commented Feb 28, 2022

Jacalz commented Mar 4, 2022

Jacalz left a comment

Choose a reason for hiding this comment

Jacalz commented Mar 4, 2022

lucor commented Mar 5, 2022 • edited Loading

Jacalz left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

Jacalz left a comment

Choose a reason for hiding this comment

lucor commented Mar 6, 2022

Jacalz left a comment

Choose a reason for hiding this comment

Jacalz left a comment • edited Loading

Choose a reason for hiding this comment

Jacalz commented Mar 7, 2022 • edited Loading

Jacalz left a comment

Choose a reason for hiding this comment

lucor commented Mar 7, 2022

lucor commented Mar 5, 2022 •

edited

Loading

Jacalz left a comment •

edited

Loading

Jacalz commented Mar 7, 2022 •

edited

Loading