Allow OnSelected of a tab to focus content

It was a refresh order issue - focus manager could not "see" new item Fixes #5454
fyne-io · Jan 27, 2025 · c750757 · c750757
1 parent e400de7
commit c750757
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/container/apptabs.go b/container/apptabs.go
@@ -161,13 +161,11 @@ func (t *AppTabs) RemoveIndex(index int) {
 // Select sets the specified TabItem to be selected and its content visible.
 func (t *AppTabs) Select(item *TabItem) {
 	selectItem(t, item)
-	t.Refresh()
 }
 
 // SelectIndex sets the TabItem at the specific index to be selected and its content visible.
 func (t *AppTabs) SelectIndex(index int) {
 	selectIndex(t, index)
-	t.Refresh()
 }
 
 // SelectTab sets the specified TabItem to be selected and its content visible.

diff --git a/container/doctabs.go b/container/doctabs.go
@@ -152,7 +152,6 @@ func (t *DocTabs) Select(item *TabItem) {
 // SelectIndex sets the TabItem at the specific index to be selected and its content visible.
 func (t *DocTabs) SelectIndex(index int) {
 	selectIndex(t, index)
-	t.Refresh()
 }
 
 // Selected returns the currently selected TabItem.

diff --git a/container/tabs.go b/container/tabs.go
@@ -195,6 +195,7 @@ func selectIndex(t baseTabs, index int) {
 
 	t.setTransitioning(true)
 	t.setSelected(index)
+	t.Refresh()
 
 	if f := t.onSelected(); f != nil {
 		// Notification of selected