Add an advanced text generator based on markov chains. #254

TimWolla · 2014-02-18T17:21:37Z

The advanced text generator's text()-generator is compatible to
Lorem's one and can be used as a drop in replacement.

Examples (The number is the maximum amount of characters, the line breaks are here for better formatting and not generated):

  10: Poor.

  20: The Duchess tucked her.

  50: Mary Ann, what are you getting on?" said the Hatter, and he.

  70: This time there could be no mistake about it—it was neither more nor l
      ess than a.

  90: She drew herself up and said very gravely, "I think I must be off, and s
      he dropped it hastily, just in time to.

 120: Very soon the Rabbit came up to her great delight, it fitted! Alice open
      ed the door and tried to make out which were the cook took the least not
      ice.

 150: I should like to be talking in its sleep, "that 'I breathe when I breath
      e!'" "It is the same height as herself. She stretched herself up on tipt
      oe and peeped over the list. Imagine.

 200: She stretched herself up on tiptoe and peeped over the list. Imagine her
       surprise when he finds out who I was when I get it home?" when it saw h
      er. "Cheshire-Puss," began Alice, rather timidly, "would you please tell
       me your history, you.

 500: However, when they liked and left off quarreling with the others. IX—W
      HO STOLE THE TARTS? The King and Queen of Hearts, she made some tarts, A
      ll on a summer day; The Knave of Hearts, carrying the King's crown on a 
      bough of a book," thought Alice, "without pictures or conversations in i
      t, "and what is the same thing," said the Cat, and vanished. Alice had f
      ound her head pressing against the ceiling, and had no reason to be seen
      —everything seemed to quiver all over with William the Conqueror." So 
      she was now the right paw 'round, "lives a March Hare. Alice gave a wear
      y sigh. "I think you ought to.

The advanced text generator's text()-generator is compatible to Lorem's one and can be used as a drop in replacement.

fzaninotto · 2014-02-24T22:09:20Z

src/Faker/Provider/Text.php

+
+namespace Faker\Provider;
+
+class Text extends \Faker\Provider\Base


Since this provider contains English text, it should probably be under the en_US locale. So I think you should commit one class with no locale and a basic text (see for instance the base Person generator), and another one, more complete with the en_US locale.

The non-locale Text provider can even be abstract, to force a proper text.

Okay, I'll change it.

After thinking about it, putting lorem ipsum text in this class brings confusion with the text class. That's why you should leave the $baseText empty and make the class abstract, to be instanciated in locales.

fzaninotto · 2014-02-24T22:17:24Z

I absolutely love that contribution. I think it adds great value to Faker. Thanks a lot!

Anahkiasen · 2014-02-24T22:17:56Z

I've been wanting something like that for a while now so I really appreciate this too.

TimWolla · 2014-02-24T23:21:08Z

@fzaninotto The updates are now added to this pull request.

fzaninotto · 2014-02-25T08:20:25Z

src/Faker/Provider/Text.php

+     * @example 'Lorem ipsum dolor sit amet'
+     * @param  integer $maxNbChars Maximum number of characters the text should contain
+     * @param  integer $indexSize Determines how many words / chars are considered for the generation of the next token (higher number = correcter, lower number = more random)
+     * @param  string $indexUnit Determines whether 'words' or 'chars' represent the basis of the generator.


To simplify, I suggest to remove the ability to generate character-based markov text. It only produces legible text with 4+ characters, and by that time it's almost equivalent to a word-based markov chain.

TimWolla · 2014-02-27T14:10:09Z

@fzaninotto Everything should be fine now.

fzaninotto · 2014-03-03T11:54:03Z

src/Faker/Provider/Text.php

+            throw new \InvalidArgumentException('indexSize must be at most 10');
+        }
+
+        if (!isset(static::$tables[$indexSize])) {


I think I see a potential bug when switching locales.

$faker = Faker\Factory::create('fr_FR'); $faker->realText(100); // generates static $table cache for French locale $faker = Faker\Factory::create('en_EN'); $faker->realText(100); // uses static $table cache for French locale, generates French text

That probably means that $tables should not be static, and therefore realText shouldn't be static either.

also, $tables is a pretty generic name. I suggest $consecutiveWords.

TimWolla · 2014-03-03T13:30:06Z

@fzaninotto Done.

fzaninotto · 2014-03-03T13:33:13Z

Awesome. I'll merge it right away. Thanks a lot for your patch!

fzaninotto · 2014-03-03T13:34:00Z

oops, sorry can't merge: tests fail.

TimWolla · 2014-03-03T15:42:27Z

oops, sorry can't merge: tests fail.

Funny, they did work on my development box though they shouldn't. Anyway: Fix gone out just now.

Even more funny: Hiphop worked.

Add an advanced text generator based on markov chains.

staabm · 2014-06-05T08:08:26Z

❤️

tablatronix · 2015-01-15T16:14:56Z

wonderful, Thanks!

Add an advanced text generator based on markov chains.

09e4b3a

The advanced text generator's text()-generator is compatible to Lorem's one and can be used as a drop in replacement.

fzaninotto reviewed Feb 24, 2014
View reviewed changes

TimWolla added 2 commits February 25, 2014 00:20

Fix several issues with markov chain Text provider

8e1a337

Add de_DE locale for Text provider

36c5974

Fix typo in de_DE/Text locale

84dd82c

fzaninotto reviewed Feb 25, 2014
View reviewed changes

Improve documentation of the Text provider

08069d4

Add Text provider to Factory

5582419

fzaninotto reviewed Mar 3, 2014
View reviewed changes

Update Text provider with the latest suggestions

8667c48

Fix tests for Text provider

4bdebac

fzaninotto added a commit that referenced this pull request Mar 3, 2014

Merge pull request #254 from TimWolla/advancedTextProvider

680b36d

Add an advanced text generator based on markov chains.

fzaninotto merged commit 680b36d into fzaninotto:master Mar 3, 2014

TimWolla deleted the advancedTextProvider branch March 3, 2014 16:00

TimWolla mentioned this pull request Oct 26, 2022

Ensure php 8.2 compatibility FakerPHP/Faker#528

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an advanced text generator based on markov chains. #254

Add an advanced text generator based on markov chains. #254

TimWolla commented Feb 18, 2014

fzaninotto Feb 24, 2014

TimWolla Feb 24, 2014

fzaninotto Mar 3, 2014

fzaninotto commented Feb 24, 2014

Anahkiasen commented Feb 24, 2014

TimWolla commented Feb 24, 2014

fzaninotto Feb 25, 2014

TimWolla commented Feb 27, 2014

fzaninotto Mar 3, 2014

fzaninotto Mar 3, 2014

TimWolla commented Mar 3, 2014

fzaninotto commented Mar 3, 2014

fzaninotto commented Mar 3, 2014

TimWolla commented Mar 3, 2014

staabm commented Jun 5, 2014

tablatronix commented Jan 15, 2015


		namespace Faker\Provider;

		class Text extends \Faker\Provider\Base

Add an advanced text generator based on markov chains. #254

Add an advanced text generator based on markov chains. #254

Conversation

TimWolla commented Feb 18, 2014

fzaninotto Feb 24, 2014

Choose a reason for hiding this comment

TimWolla Feb 24, 2014

Choose a reason for hiding this comment

fzaninotto Mar 3, 2014

Choose a reason for hiding this comment

fzaninotto commented Feb 24, 2014

Anahkiasen commented Feb 24, 2014

TimWolla commented Feb 24, 2014

fzaninotto Feb 25, 2014

Choose a reason for hiding this comment

TimWolla commented Feb 27, 2014

fzaninotto Mar 3, 2014

Choose a reason for hiding this comment

fzaninotto Mar 3, 2014

Choose a reason for hiding this comment

TimWolla commented Mar 3, 2014

fzaninotto commented Mar 3, 2014

fzaninotto commented Mar 3, 2014

TimWolla commented Mar 3, 2014

staabm commented Jun 5, 2014

tablatronix commented Jan 15, 2015