Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cfg wasm warnings #2329

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

patmuk
Copy link
Contributor

@patmuk patmuk commented Sep 29, 2024

Changes

@fzyzcjy as suggested in #2308 (comment) this fixes all #[cfg(wasm)] warnings by turning them Into #[cfg(target_family = "wasm")].

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

patmuk added a commit to patmuk/flutter_rust_bridge that referenced this pull request Sep 29, 2024
@patmuk patmuk mentioned this pull request Sep 29, 2024
5 tasks
@fzyzcjy fzyzcjy merged commit 09d3194 into fzyzcjy:master Sep 30, 2024
135 checks passed
@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 30, 2024

Looks good!

@patmuk patmuk deleted the fixes-cfg-wasm-warnings branch October 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants