Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing conversion to T #568

Merged
merged 2 commits into from
Nov 8, 2016
Merged

Fixed missing conversion to T #568

merged 2 commits into from
Nov 8, 2016

Conversation

patrikhuber
Copy link

This makes ortho work with GLM_FORCE_UNRESTRICTED_GENTYPE.

@patrikhuber
Copy link
Author

patrikhuber commented Nov 7, 2016 •
edited
Loading

By the way, is there any pattern on when to use static_cast<T>(var) and when to use T(var)?

@Groovounet
Copy link
Member

It should be static_cast and when it's not, it's an accident / legacy / bug.

@Groovounet Groovounet added the bug label Nov 8, 2016
@Groovounet Groovounet added this to the GLM 0.9.8 milestone Nov 8, 2016
@Groovounet Groovounet self-assigned this Nov 8, 2016
@JesseTG
Copy link

JesseTG commented Nov 8, 2016

Methinks a CONTRIBUTING.md with style-guide information like that wouldn't be such a bad thing.

@patrikhuber
Copy link
Author

I've changed it to static_cast.

@Groovounet Groovounet merged commit 3db25fe into g-truc:master Nov 8, 2016
@Groovounet
Copy link
Member

Thanks for contributing!

@patrikhuber
Copy link
Author

Thank you for coding and maintaining this great library :-)

@patrikhuber patrikhuber deleted the fix-missing-cast-to-T branch November 8, 2016 20:07
Groovounet added a commit that referenced this pull request Nov 9, 2016
@Groovounet
- Fixed interaction between GLM_FORCE_UNRESTRICTED_GENTYPE and ortho …
30db341 
…function #568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Groovounet Groovounet

Labels
bug
Projects
None yet
Milestone
GLM 0.9.8
Development

Successfully merging this pull request may close these issues.
3 participants
@patrikhuber @Groovounet @JesseTG